Fix openmp #42
Open
Fix openmp #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is strange that it failed, I need to investigate this. |
|
Dear Oto,
Merge pull request #29 from kousuke-nakano/devel-#24 <https://github.com/sissaschool/turborvb/actions/runs/4967748101>
Yes, this is strange. The zgemm failed :-(
… On May 14, 2023, at 1:21, addman2 ***@***.***> wrote:
This is strange that it failed, I need to investigate this.
—
Reply to this email directly, view it on GitHub <#42 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI7IYQNHHBT75UT4QDVM4SDXF6YITANCNFSM6AAAAAAYASKRCI>.
You are receiving this because your review was requested.
|
|
Dear @addman2, did you pinpoint the problem? |
|
Dear @addman2 , I will investigate this problem if you have not solved it. Let me know :-) |
|
Hi Kosuke, it was partly solved. When turbo is compiled with the old build system (actually new build system based on makefile it was completly redesigned) the problem disappeared. I wrote the makefile build system to solve this issue. So now we know the problem is somewhere in CMake. I need to do careful comparision between those two to find where is the problem. Towards end of this week I will be more free so I can look at it again. |
|
Dear @addman2, thanks!!! Let me know if there is something I can contribute to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix problem with OpenMP. CPU only.