Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add old build #72

Merged
merged 9 commits into from
Jan 30, 2024
Merged

Add old build #72

merged 9 commits into from
Jan 30, 2024

Conversation

addman2
Copy link
Collaborator

@addman2 addman2 commented Jul 14, 2023

I added old build system. It is not the same, but CMake sometimes produces problems. CMake is good if everything works, but for optimizing a development is better to have simplier build system. This one is very simple. Now it only works for turborvb executatble, for testing it is enough.

Copy link
Collaborator

@kousuke-nakano kousuke-nakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @addman2. I am very sorry for my late comments!! I totally forgot to review these changes. Yes, the make.inc files are quite helpful!! I just wonder if I can add an make.inc to test/ directory, which should be quite useful when implementing new tests. What do you think?

@kousuke-nakano kousuke-nakano added the enhancement New feature or request label Sep 6, 2023
@kousuke-nakano
Copy link
Collaborator

Dear @addman2, Sorry! I totally forgot to merge it. I would like to merge it asap since the old build system you have made is quite useful for non-standard architectures. Would you check my review?

@addman2
Copy link
Collaborator Author

addman2 commented Dec 6, 2023

Hi @kousuke-nakano ,

So I did multiple changes. First selection of aggressive and non-agressive flags did not worked. I had to fix it. Also I added some make.inc. You even dont have to copy them, if you run make withouthem they will be copied automatically.

This build system works a little bit differently when compared to the previous one. You specifies out-of-ource build directory and compile aither serial or parallel version.

Another thing is only turborvb executable is build by this. I can later add other.

Tell me if you need more.

@kousuke-nakano
Copy link
Collaborator

Dear @addman2, thank you very much!! I will test the makefile tomorrow, then merge this pull-request!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @addman2, here you include both make.txt and make.inc. what is the difference?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @addman2, could you provide an example make.inc? (I guess it is the same as the old turbo's one).

@kousuke-nakano kousuke-nakano merged commit 00fbaf6 into sissaschool:devel Jan 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants