Merge branch 'main' into offset

sitespeedio · Dec 19, 2024 · b6a01a6 · b6a01a6
2 parents 11cd9b6 + c83cb81
commit b6a01a6
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Browsertime changelog (we do [semantic versioning](https://semver.org))
 
+## 23.4.4 -  2024-12-18
+### Fixed
+* A more robust gnirehtet check when you run your Android test [#2223](https://github.com/sitespeedio/browsertime/pull/2223).
+
 ## 23.4.3 -  2024-12-11
 ### Fixed
 * Update to USB power profiling 1.5.0 [#2221](https://github.com/sitespeedio/browsertime/pull/2221).

diff --git a/lib/core/engine/index.js b/lib/core/engine/index.js
@@ -93,7 +93,7 @@ export class Engine {
       await android._init();
       this.android = android;
 
-      if (options.gnirehtet) {
+      if (options.gnirehtet === true) {
         this.gnirehtet = new Gnirehtet(options);
         await this.gnirehtet.start();
       }
@@ -520,7 +520,7 @@ export class Engine {
       }
     }
 
-    if (options.gnirehtet && this.gnirehtet) {
+    if (options.gnirehtet === true && this.gnirehtet) {
       await this.gnirehtet.stop();
     }
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "browsertime",
   "description": "Get performance metrics from your web page using Browsertime.",
-  "version": "23.4.3",
+  "version": "23.4.4",
   "bin": "./bin/browsertime.js",
   "type": "module",
   "types": "./types/scripting.d.ts",