Preparing for setting headers when FF supports it in Bidi (Firefox 1XX) #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soulgalore
changed the title
6 tasks
lib/firefox/firefoxBidi.js
Outdated
| method: 'network.continueRequest', | ||
| params: { | ||
| request: parsedEvent.params.request.request, | ||
| headers |
There was a problem hiding this comment.
Mentioned it on bugzilla, but here you should merge your headers with the current request headers.
Suggested change
| headers | |
| [headers](headers: [...parsedEvent.params.request.headers, ...headers],) |
There was a problem hiding this comment.
Ah thank you! I got confused since I got "success" without the rest of the headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example on how to set request headers in Bidi if will be available in continueRequest?