Added 'clear' messages as a configurable option #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metju90
changed the title
|
MailCatcher should not be used as a durable store for messages, it uses an in-memory database, so I'm not sure I'm keen on adding this as an option. What's your use case here; why don't you want emails to be cleared? |
|
For my case: we use mailcatcher for recipe environments where many users have access. So it happens that users click on it and delete everyone's mails. So I removed the "clear" button and put a limit to keep only the last 300 messages. |
|
@damienfinck how did you remove the clear button? |
|
@shub-qantas I took the code from the master branch, applied this PR and regenerated the mailcatcher application in a Docker container so I can deploy it anywhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We planned to persist the emails caught by this software but unfortunately one colleague was not aware of this and deleted all emails by pressing "clear".
This motivated me to open this PR, to have the "clear" button as a config option.