Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop legacy Ruby versions, including 3.0 #554

Merged
merged 1 commit into from
May 17, 2024
Merged

Drop legacy Ruby versions, including 3.0 #554

merged 1 commit into from
May 17, 2024

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented Jan 16, 2024 •
edited
Loading

3.0 will EOL soon, and it has issues when compiling eventmachine

Also:

  • Fix compatibility with latest Selenium
  • Bump Sinatra and Rack dependency to allow Ruby 3.3

Close #553

@tagliala tagliala force-pushed the feature/drop-legacy-ruby-versions branch 2 times, most recently from bded7d2 to b524dc0 Compare January 16, 2024 08:02
@tagliala
Drop legacy Ruby versions, including 3.0
5684787 
3.0 will EOL soon, and it has issues when compiling eventmachine

Also:

- Fix compatibility with latest Selenium
- Bump Sinatra and Rack dependency to allow Ruby 3.3
- Bump version to 0.10.0.alpha1

Close sj26#553
@tagliala tagliala force-pushed the feature/drop-legacy-ruby-versions branch from b524dc0 to 5684787 Compare January 16, 2024 08:07
@tagliala tagliala changed the title Drop legacy Ruby versions Drop legacy Ruby versions, including 3.0 Jan 16, 2024
@FinnIckler
Copy link

While Mailcatcher starts now, assets are not served.

curl localhost:1080/assets/mailcatcher.js
<html>
<body>
  <h1>No Dice</h1>
  <p>The message you were looking for does not exist, or doesn't have content of this type.</p>
</body>
</html>

@tagliala
Copy link
Contributor Author

tagliala commented Feb 6, 2024

Cannot replicate on my machine 🤔

$ curl localhost:1080/assets/mailcatcher.js
window.Modernizr=function(e,t,r){function n(e)...

command line:

BUNDLE_GEMFILE=~/dev/mailcatcher/Gemfile bundle exec ~/dev/mailcatcher/bin/mailcatcher -f -v --http-ip=0.0.0.0

@FinnIckler
Copy link

Here's a repro

docker run -it ruby:3.3.0 /bin/bash
# installing your gem
gem install specific_install && gem specific_install -l https://github.com/tagliala/mailcatcher.git -b feature/drop-legacy-ruby-versions
mailcatcher --http-ip=0.0.0.0 --no-quit
curl localhost:1080/assets/mailcatcher.js

@FinnIckler
Copy link

Ok, me and a colleague figured out that this is because the coffeescript files don't get compiled when installing the gem from this repo

@tagliala
Copy link
Contributor Author

tagliala commented Feb 6, 2024 •
edited
Loading

yes, the asset compile pipeline is quite outdated. It compiles on my machine but with several warnings :(

@tagliala tagliala marked this pull request as ready for review February 6, 2024 22:00
@sj26
Copy link
Owner

sj26 commented May 17, 2024

Sorry for the delay, but this is wonderful, thank you.

@sj26 sj26 merged commit df4a733 into sj26:main May 17, 2024
6 checks passed
This was referenced May 17, 2024
Open
Closed
@tagliala tagliala deleted the feature/drop-legacy-ruby-versions branch May 17, 2024 08:23
@ansonhoyt
Copy link

Can confirm it's working with Ruby 3.3.0 (and Rails 7.1) after gem install mailcatcher --pre. Happy to have this nice tool working again, just in time to develop some new emails. 😅

Thanks all for the fix and release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.9.1.beta2 does not work with Ruby 3.3
4 participants
@tagliala @FinnIckler @sj26 @ansonhoyt