Updating the solution to support Material Icons. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hope you had a good weekend, I just wondered if you had a chance to look at my PR and if you needed me to do anything else to get it merged in? Cheers, Chris |
|
Hey Chris,
I'll be overseas for a couple of weeks so I won't have time to check your
PR. I'll take a look as soon as I come back.
Thanks.
…On Tue, 12 Sept 2023, 03:47 Chris Houston, ***@***.***> wrote:
@skartknet <https://github.com/skartknet>
I hope you had a good weekend, I just wondered if you had a chance to look
at my PR and if you needed me to do anything else to get it merged in?
Cheers,
Chris
—
Reply to this email directly, view it on GitHub
<#39 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM3ODR3EIJP234PI4GPBDLXZ5FDXANCNFSM6AAAAAA4P2FT6I>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@skartknet - No problem, enjoy your time away :) |
|
Just a little ping in case you are back :) |
skartknet
approved these changes
Sep 29, 2023
|
Hi @readingdancer , yes I'm back ;). This PR looks great, thanks so much! I will include it in the next version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @skartknet
I think the Material Icons codepoints files have changed since you last looked at them, they are now plain text file and not JSON data :)
I created this PR will all the changes required to support Material Icons, I have added a couple of extra error messages to help any developers who choose to use Material Icons and I have updated the relevant help page.
I have allowed
.codepointsfiles to be selected so that in theory the original files can be used without any requirement to rename them, however as I have explained in the documentation, the web server serving this file has to support the MIME type.I also added an error message in case someone tries to use this extension and they get a 404 error, as this is likely to be their issue.
I have changed the Regex in the preconfigs.json file and I have added some additional localization words to the US English XML file, sorry I can't help with the Spanish translations, perhaps you can add them?
I also updated all the Material Icons example files in each of your text Umbraco folders so it should be pretty easy to test them locally.
Cheers,
Chris