Add edebug specificatons to almost all defmacros #458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These declarations make it possible to step through the &body forms of
the macros, as opposed to skipping over them entirely while
edebugging.
I've tested all the specifications I've added, except for
with-elfeed-web
since I don't use elfeed-web. However, that macro only has body forms, so the debug specification is extremely simple.I also attempted to declare an edebug specification to
xml-query*
andxml-query-all*
, and I believe it correctly matches the structure given by the docstring ofxml-query-all
, but I didn't notice any difference in behaviour when Edebugging, for valid or invalid input.Heres that attempt:
make check
reports that all tests pass.