Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/theme-generator-invalid-rgb #1745

Merged

Conversation

Mahmoud-zino
Copy link
Contributor

Linked Issue

Closes #1744

Description

for now, it is not easy to validate colors before saving the value to local storage without introducing big changes.

however, resetting invalid colors on component initialization will solve the problem.

when refactoring the component we might want to introduce a callback function in our LocalStorageStore utility so we can validate colors before saving them to localStorage (I think this would be a cool feature).

Changsets

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2023

⚠️ No Changeset found

Latest commit: ed80328

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jul 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Jul 12, 2023 6:07pm

@A-iko
Copy link

A-iko commented Jul 13, 2023

Thank you for your patience.
Tried it out! This seems to resolve this issue both on a page reload, page switch and switching between document pages.
👍

Copy link
Member

@AdrianGonz97 AdrianGonz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected!

@endigo9740 endigo9740 merged commit 7d7c930 into skeletonlabs:dev Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid RGB Value! - Breaks the theme generator in perpetuity
4 participants