Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: theme generator use selected theme colors #1930

Closed

Conversation

ak4zh
Copy link
Contributor

@ak4zh ak4zh commented Aug 23, 2023

Linked Issue

Closes #1179
Issue was closed but not implemented as it was moved to #1142

Description

Theme generator will use the current selected theme colors as well as text-on color.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages/skeleton, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2023

🦋 Changeset detected

Latest commit: d0f19b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skeleton.dev Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Aug 23, 2023 1:00pm

@ak4zh
Copy link
Contributor Author

ak4zh commented Aug 23, 2023

Seems this is not ready yet for review, and I don't know how to convert back to draft mode.
I will re-open later after discussing whether to implement it or leave to be taken care of on the Theme Generator overhaul.

@ak4zh ak4zh closed this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant