-
-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEXT: Update components to use Zag.js #2778
Conversation
🦋 Changeset detectedLatest commit: 62adb69 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Hugos68 is attempting to deploy a commit to the Skeleton Labs Team on Vercel. A member of the Team first needs to authorize it. |
This PR integrates Zag into our existing suite of Svelte and React components. This also updates the respective documentation and examples for each component.
The following indicates the status of updates per components:
Also implements:
useId()
local utility function forskeleton-svelte
Remaining Tasks
schema.ts
information is up to dateDocumentation:
onValueChange
)disable
Framework Components:
data-testid
attributes@component
component comment descriptions// Zag
comment (see Ratings)flex-1
class in template - needs to be move to style propvalue
needs to be provided tocontext: {}
ala Segment Control, etcdisabled
prop is non-functional and not visually displayedcontext: {}
(ex: checked, disabled, compact)Post-Release Tasks
<figure>
for data visualization componentsChecklist
Please read and apply all contribution requirements.
docs/
,feature/
,chore/
,bugfix/
next
branch (NEVERdev
ormaster
)pnpm check
in the root of the monorepopnpm format
in the root of the monorepopnpm lint
in the root of the monorepopnpm test
in the root of the monorepo/package
projects, please supply a ChangesetChangsets
View our documentation to learn more about Changesets. To create a Changeset:
pnpm changeset
and follow the prompts