Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT: Themes and Generator Overhaul #2852

Draft
wants to merge 44 commits into
base: next
Choose a base branch
from

Conversation

endigo9740
Copy link
Contributor

@endigo9740 endigo9740 commented Sep 10, 2024

Linked Issue

#1142

Description

As much as possible, the goal is to solidify theme formats and the generator to reach launch status.

  • Finalizes theme format
  • Overhauls theme generator app state, code, and logic
  • Re-generate v3 themes to take advantage of improvements
  • Create spiritual successors to v2 themes

Checklist

Please read and apply all contribution requirements.

  • Your branch should be prefixed with: docs/, feature/, chore/, bugfix/
  • Skeleton v3 contributions must target the next branch (NEVER dev or master)
  • Documentation should be updated to describe all relevant changes
  • Run pnpm check in the root of the monorepo
  • Run pnpm format in the root of the monorepo
  • Run pnpm lint in the root of the monorepo
  • Run pnpm test in the root of the monorepo
  • If you modify /package projects, please supply a Changeset

Changsets

View our documentation to learn more about Changesets. To create a Changeset:

  1. Navigate to the root of the monorepo in your terminal
  2. Run pnpm changeset and follow the prompts
  3. Commit and push the changeset before flagging your PR review for review.

Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skeleton-docs ❌ Failed (Inspect) Sep 20, 2024 7:05pm
skeleton-themes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 7:05pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
skeleton-next ⬜️ Ignored (Inspect) Sep 20, 2024 7:05pm

Copy link

changeset-bot bot commented Sep 10, 2024

⚠️ No Changeset found

Latest commit: 0e89f96

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants