-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/#2867 Fixes popup disappearing in Input Autocompete #2937
Merged
endigo9740
merged 8 commits into
skeletonlabs:dev
from
nullpointerexceptionkek:bugfix/2867
Dec 17, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
84aa0f5
bugfix: Close popup when clicking outside only if there is no text se…
nullpointerexceptionkek 650705a
bugfix: Fix popup disappearing when dragging mouse out of the input box
nullpointerexceptionkek 695bee2
Fix unnecessary console.log statement in popup.ts
nullpointerexceptionkek 2618576
bugfix: Fix popup disappearing when dragging mouse out of the input box
nullpointerexceptionkek a0c1eb6
fix: Add mouseup event listener to close popup when dragging along text
nullpointerexceptionkek a7d5803
fix: Close popup when clicking outside only if there is no text selec…
nullpointerexceptionkek ec52309
Merge branch 'skeletonlabs:dev' into bugfix/2867
nullpointerexceptionkek 2102a85
fix: Increase timeout for getting wrapper element in Toast test
nullpointerexceptionkek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@skeletonlabs/skeleton": patch | ||
--- | ||
|
||
bugfix: fix popup disappearing when dragging mouse out of the input box |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@endigo9740 After a bit of digging, I think this is the root cause for #3075.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phamduylong I see. Well I'd welcome a fix if possible. We're only due for about 1 more release of v2 before we archived it, but I'm certain I'm not going to have time to address this directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nullpointerexceptionkek FYI as well in case you guys want to talk through this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take a look at it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function handleMouseUp is a fix, or else when the user have an popup open and copies a text outside by dragging the mouse, the popup will not be closed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have PR the changes @phamduylong