Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: CloseQuery has no efffect/Popup close on click #3076

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
+6 −1
Open

Bugfix: CloseQuery has no efffect/Popup close on click #3076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/slow-dancers-stare.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@skeletonlabs/skeleton": minor
---

Fix CloseQuery has no effect and popup disappear on click
2 changes: 1 addition & 1 deletion packages/skeleton/src/lib/utilities/Popup/popup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ export function popup(triggerNode: HTMLElement, args: PopupSettings) {
}

function handleMouseUp(event: MouseEvent) {
if (!triggerNode.contains(event.target as Node)) close();
if (!triggerNode.contains(event.target as Node) && !elemPopup.contains(event.target as Node)) close();
}

function onWindowClick(event: any): void {
Expand Down
Loading