feat(adapters): Add SignerExtractionAdapter [ENG-1916] #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidterpay
approved these changes
Sep 21, 2023
| ) | ||
|
|
||
| type SignerData struct { | ||
| Signer sdk.AccAddress |
There was a problem hiding this comment.
Curious to hear what you think, but I wonder if this needs to be an sdk.AccAddress or just a string. Also, we should probably bring this up to the cosmos sdk team. Ideally, we upstream these changes for others to also have, but for time being this works.
davidterpay
added
backport/v1.x.x
|
idk why it commented twice. xD |
mergify bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
* add a signer-extraction-adapter * linting * feat(adapters/mev-lane): Use the SignerExtractionAdapter in the Mev-Lane [ENG-1917] (#115) * use SignerExtractionAdapter in the Factory * feat(e2e): block sdk integration updates (#122) * cherry-pick from injective * remove transactions from app-side mempool on failed re-checktx (cherry picked from commit 3abfde4) # Conflicts: # Makefile # abci/abci_test.go # block/base/config.go # block/base/mempool.go # block/mempool_test.go # lanes/base/abci_test.go # lanes/base/mempool_test.go # lanes/mev/check_tx.go # lanes/mev/factory.go # lanes/mev/mev_test.go # tests/app/app.go # tests/integration/chain_setup.go # tests/integration/go.mod # tests/integration/go.sum # tests/integration/pob_suite.go # x/auction/ante/ante_test.go
mergify bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
* add a signer-extraction-adapter * linting * feat(adapters/mev-lane): Use the SignerExtractionAdapter in the Mev-Lane [ENG-1917] (#115) * use SignerExtractionAdapter in the Factory * feat(e2e): block sdk integration updates (#122) * cherry-pick from injective * remove transactions from app-side mempool on failed re-checktx (cherry picked from commit 3abfde4)
This was referenced Sep 27, 2023
nivasan1
added a commit
that referenced
this pull request
Sep 27, 2023
* add a signer-extraction-adapter * linting * feat(adapters/mev-lane): Use the SignerExtractionAdapter in the Mev-Lane [ENG-1917] (#115) * use SignerExtractionAdapter in the Factory * feat(e2e): block sdk integration updates (#122) * cherry-pick from injective * remove transactions from app-side mempool on failed re-checktx (cherry picked from commit 3abfde4) Co-authored-by: Nikhil Vasan <[email protected]>
nivasan1
added a commit
that referenced
this pull request
Sep 27, 2023
* add a signer-extraction-adapter * linting * feat(adapters/mev-lane): Use the SignerExtractionAdapter in the Mev-Lane [ENG-1917] (#115) * use SignerExtractionAdapter in the Factory * feat(e2e): block sdk integration updates (#122) * cherry-pick from injective * remove transactions from app-side mempool on failed re-checktx
nivasan1
added a commit
that referenced
this pull request
Sep 27, 2023
* add a signer-extraction-adapter * linting * feat(adapters/mev-lane): Use the SignerExtractionAdapter in the Mev-Lane [ENG-1917] (#115) * use SignerExtractionAdapter in the Factory * feat(e2e): block sdk integration updates (#122) * cherry-pick from injective * remove transactions from app-side mempool on failed re-checktx
nivasan1
added a commit
that referenced
this pull request
Sep 27, 2023
* add a signer-extraction-adapter * linting * feat(adapters/mev-lane): Use the SignerExtractionAdapter in the Mev-Lane [ENG-1917] (#115) * use SignerExtractionAdapter in the Factory * feat(e2e): block sdk integration updates (#122) * cherry-pick from injective * remove transactions from app-side mempool on failed re-checktx
nivasan1
added a commit
that referenced
this pull request
Sep 27, 2023
* add a signer-extraction-adapter * linting * feat(adapters/mev-lane): Use the SignerExtractionAdapter in the Mev-Lane [ENG-1917] (#115) * use SignerExtractionAdapter in the Factory * feat(e2e): block sdk integration updates (#122) * cherry-pick from injective * remove transactions from app-side mempool on failed re-checktx
nivasan1
added a commit
that referenced
this pull request
Sep 27, 2023
* add a signer-extraction-adapter * linting * feat(adapters/mev-lane): Use the SignerExtractionAdapter in the Mev-Lane [ENG-1917] (#115) * use SignerExtractionAdapter in the Factory * feat(e2e): block sdk integration updates (#122) * cherry-pick from injective * remove transactions from app-side mempool on failed re-checktx Co-authored-by: Nikhil Vasan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In This PR
adaptersdirectory (this contains any weird interfaces that we expect to change across chainsSignerExtractionAdapterwhich gets the chains + nonces from the txDefault, and create the interface to be amicable to the evmos tx-types (i.e both MsgEthereumTxs / EIP-712 signed cosmos-txs)PriorityNonceMempoolTODOs
AuctionFactory) will need to be changed to use theSignerExtractionAdapterI'll do that in a PR on top of this