Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Remove double hashing (backport #517) #519

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 18, 2024

Remove two hashes here.

All CheckTx calls are synchronous from Tendermint, so theres no race condition concerns I missed. If there were race condition concerns, then we should do a single hash and then do a quick check for if things are contained in cache.


This is an automatic backport of pull request #517 done by Mergify.

(cherry picked from commit 2ae5b14)
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/v2.x.x@147396b). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/v2.x.x     #519   +/-   ##
=================================================
  Coverage                  ?   49.20%           
=================================================
  Files                     ?       39           
  Lines                     ?     1693           
  Branches                  ?        0           
=================================================
  Hits                      ?      833           
  Misses                    ?      768           
  Partials                  ?       92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidterpay davidterpay merged commit 91ff560 into release/v2.x.x Jun 18, 2024
11 of 12 checks passed
@davidterpay davidterpay deleted the mergify/bp/release/v2.x.x/pr-517 branch June 18, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants