-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Evict txs from mempool exceeding size limits #550
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -49,7 +49,6 @@ func (h *ProposalHandler) PrepareLaneHandler() base.PrepareLaneHandler { | |||
} | |||
|
|||
cacheCtx, write := ctx.CacheContext() | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test for this would be nice, and pretty easy to write if you just set max gas/bytes to small numbers right?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
==========================================
- Coverage 43.91% 43.59% -0.32%
==========================================
Files 63 63
Lines 2792 2812 +20
==========================================
Hits 1226 1226
- Misses 1439 1459 +20
Partials 127 127 ☔ View full report in Codecov by Sentry. |
There are tests for this, just added an additional condition check to ensure the tx was removed from the mempool |
|
not sure why codecov is saying no coverage when the test case hits that exact line of code. check cc: @Eric-Warehime |
* init * nit test case (cherry picked from commit b8d9c22)
* init * nit test case (cherry picked from commit b8d9c22)
* init * nit test case (cherry picked from commit b8d9c22) Co-authored-by: David Terpay <[email protected]>
* init * nit test case (cherry picked from commit b8d9c22) Co-authored-by: David Terpay <[email protected]>
No description provided.