Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix user permissions #710

Merged
merged 2 commits into from
Aug 28, 2024
Merged

chore: Fix user permissions #710

merged 2 commits into from
Aug 28, 2024

Conversation

Eric-Warehime
Copy link
Collaborator

Setting a new user in this way ends up with issues when using an entrypoint command since no entries exist in the corresponding etc/ files.

I tried setting the nobody user which is built into distroless images, but then mounting files in to use as a config becomes an issue. It seems pretty low stakes to give users root inside the distroless container, so I'm just reverting for now.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.54%. Comparing base (7391885) to head (4fa52d4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #710      +/-   ##
==========================================
+ Coverage   56.53%   56.54%   +0.01%     
==========================================
  Files         257      257              
  Lines       13505    13505              
==========================================
+ Hits         7635     7637       +2     
+ Misses       5133     5131       -2     
  Partials      737      737              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aljo242 aljo242 merged commit ca5de1c into main Aug 28, 2024
17 checks passed
@aljo242 aljo242 deleted the eric/fix-user-e2e-tests branch August 28, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants