Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up market map hooks #778

Merged
merged 4 commits into from
Sep 30, 2024
Merged

fix: clean up market map hooks #778

merged 4 commits into from
Sep 30, 2024

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Sep 27, 2024

Actually call the hook and clean it up to only use the ticker key as opposed to the whole market

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 57.00%. Comparing base (2c36ea8) to head (e18596e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/marketmap/types/hooks.go 0.00% 3 Missing ⚠️
x/marketmap/keeper/msg_server.go 0.00% 1 Missing and 1 partial ⚠️
x/oracle/keeper/hooks.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #778   +/-   ##
=======================================
  Coverage   56.99%   57.00%           
=======================================
  Files         210      210           
  Lines       11718    11720    +2     
=======================================
+ Hits         6679     6681    +2     
+ Misses       4431     4430    -1     
- Partials      608      609    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a test we can add to make sure the hook is called as expected?

@aljo242 aljo242 merged commit fc1e299 into main Sep 30, 2024
13 of 14 checks passed
@aljo242 aljo242 deleted the feat/clean-up-hooks branch September 30, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants