fix: sidecar no longer checks LastUpdated
#800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljo242
requested review from
Eric-Warehime,
technicallyty,
wesl-ee and
zrbecker
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #800 +/- ##
==========================================
+ Coverage 56.98% 57.31% +0.33%
==========================================
Files 213 213
Lines 14801 14823 +22
==========================================
+ Hits 8434 8496 +62
+ Misses 5757 5713 -44
- Partials 610 614 +4 ☔ View full report in Codecov by Sentry. |
zrbecker
approved these changes
Oct 22, 2024
| // - returns false if the market map is not updated | ||
| // - returns true and the new market map if the new market map is updated and valid. | ||
| func (o *OracleImpl) IsMarketMapValidUpdated(resp *mmtypes.MarketMapResponse) (mmtypes.MarketMap, bool, error) { | ||
| if resp == nil { |
There was a problem hiding this comment.
Looks like we didn't check for result.Value to be nil before, are we checking it now because we are not sure if it can be nil, or just because we are exposing this as a function?
There was a problem hiding this comment.
It should not be nil if it is returned from x/marketmap, but since the client is generic, its good to have nil checks in place since this is now a function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of CON-1839
This is a sidecar level fix that reverts the check of
LastUpdatedto checking equality of the incoming market map updates.Factor out updating check to
IsMarketMapValidUpdatedwhich now has testing.The market equality check can be reverted to the LastUpdated check once we are using on-chain logic with this PR.