Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unavailable device tracker #11

Merged
merged 2 commits into from
Sep 21, 2024
Merged

Fix unavailable device tracker #11

merged 2 commits into from
Sep 21, 2024

Conversation

WebSpider
Copy link
Contributor

When a car does not transmit it's coordinates, or has coordinates turned off, this causes an error in the current integration. Should be fixed with this update.

@Prior99
Copy link
Contributor

Prior99 commented Sep 17, 2024

There is unrelated changes in the poetry.lock file.
I would suggest to search for a position with type == PositionType.VEHICLE instead of accessing the first element.

Copy link
Member

@dvx76 dvx76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with optional nits to address if you want.

Pet peeve: when updating from main do a rebase intead of merging main into the branch 😅

custom_components/myskoda/device_tracker.py Outdated Show resolved Hide resolved
custom_components/myskoda/device_tracker.py Outdated Show resolved Hide resolved
@Prior99
Copy link
Contributor

Prior99 commented Sep 21, 2024

I rebased this and added a check to whether the position is of type PositionType.VEHICLE.

@Prior99 Prior99 merged commit 60871ed into main Sep 21, 2024
6 checks passed
@WebSpider WebSpider deleted the fix-devicetracker branch September 23, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants