Disable ChargeLimit and BatteryCare forSuperb iV #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvx76
approved these changes
Nov 5, 2024
| @@ -78,3 +78,6 @@ async def async_set_native_value(self, value: float): # noqa: D102 | |||
|
|
|||
| def required_capabilities(self) -> list[CapabilityId]: | |||
| return [CapabilityId.CHARGING] | |||
|
|
|||
| def forbidden_capabilities(self) -> list[CapabilityId]: | |||
There was a problem hiding this comment.
off-topic: kinda wondering why we didn't make required_capabilities a class attribute (= [] in the base MySkodaEntity). Seems a bit cleaner than overloaded methods.
There was a problem hiding this comment.
Yes that makes complete sense in retrospect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166
Needs testing