-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
258 shape #277
Conversation
@acka47 I suggest trying out by pulling this branch and testing against valid and invalid SKOS turtle files with |
This seems to work fine. However, the error messages are not easy to parse for the human eye. Would it be possible to provide the path to the file where an error is located? This might already help. Or also provide the
|
It would also be good if violations could be highlighted somehow in the validation list. It would make things easier, if you have a lot of warnings and only one violation. |
Violations are now indicated with a red Error message. Violations and Warnings are now differentiated. The filepath is also provided. `dct:title` is not yet available when I'm testing, since I want to fail as early as possible, avoiding possible other bugs rising from invalid SKOS files.
Violations are now indicated with a red Error message.
|
@acka47 Please review the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 I think this is fine for now. We can always improve it when more user feedback comes in.
SKOS files are now validated against the SkoHub shape (https://github.com/skohub-io/shapes/blob/main/skohub.shacl.ttl).
If the files violate the shape the build will stop.
If the files hit warnings, the build will continue, but the error message will still be printed to the console.