tablereport display details #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's hard to see what changes, can you provide screenshots? |
|
sure, it's really a detail. it is just about alignment of the dropdown when there is a very narrow display before:
after:
|
|
the change on the tab margin is just that on a high-resolution large screen at some zoom levels in jupyter notebooks only I could see a very thin gray line between the selected tab and its panel, but I can't seem to reproduce it on my laptop to provide a screenshot |
jeromedockes
changed the title
|
Hey @jeromedockes, is this PR ready for review? |
|
Hey @jeromedockes, is this PR ready for review?
yes, thank you!
|
|
Well, I would have appreciated reviewing it before merging. |
jeromedockes
added a commit
to jeromedockes/skrub
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a small detail so it is aligned when wrapping