Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorting of the summary statistics table #1068

Merged
merged 12 commits into from
Sep 16, 2024

Conversation

jeromedockes
Copy link
Member

@jeromedockes jeromedockes commented Sep 10, 2024

it is now possible to sort the table in the "stats" tab panel eg from columns with fewest null values to most null values

WIP:

  • add tests
  • improve a bit the look & position of the buttons

@Vincent-Maladiere
Copy link
Member

Nice addition, is it possible to remove the shadow around the buttons?

@jeromedockes
Copy link
Member Author

@Vincent-Maladiere I removed the shadows and also changed the icons for something more explicit. it should be ok now

Copy link
Member

@Vincent-Maladiere Vincent-Maladiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vincent-Maladiere Vincent-Maladiere merged commit a043903 into skrub-data:main Sep 16, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants