Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update lock files #1129

Merged
merged 2 commits into from
Nov 6, 2024
Merged

update lock files #1129

merged 2 commits into from
Nov 6, 2024

Conversation

jeromedockes
Copy link
Member

@jeromedockes jeromedockes commented Oct 28, 2024 •
edited
Loading

closes #1128

based on the skrub-bot branch to update the lock file; one test needs to be adjusted

Vincent-Maladiere
Vincent-Maladiere approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@Vincent-Maladiere Vincent-Maladiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha I didn't see this PR and added the same fix in the TextEncoder PR

@Vincent-Maladiere Vincent-Maladiere merged commit cb391c5 into skrub-data:main Nov 6, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vincent-Maladiere Vincent-Maladiere Vincent-Maladiere approved these changes

Assignees
No one assigned
Labels
no changelog needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeromedockes @Vincent-Maladiere @web-flow