-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a "Discover" object for finding candidate tables that may be joined on the main table #1153
Draft
rcap107
wants to merge
10
commits into
skrub-data:main
Choose a base branch
from
rcap107:discover
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a8ca6e7
🎉 Initial commit for the Discover object
rcap107 55a7866
Merge remote-tracking branch 'upstream/main' into discover
rcap107 a73a114
Updating gitignore
rcap107 5b65db2
Cleaning up, moving code to source dir
rcap107 02017fa
Adding example
rcap107 abc9174
Updating common with the new functions
rcap107 df3b4dd
Starting to implement datframe API
rcap107 fc064cd
Updating gitignore
rcap107 920546b
Initial commit
rcap107 7bcb0d1
Updating code to test on CTU example
rcap107 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,9 @@ var/ | |
.installed.cfg | ||
*.egg | ||
*.pkl | ||
data/ | ||
|
||
data/ | ||
|
||
.pytest_cache/ | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
# %% | ||
import polars as pl | ||
|
||
from skrub._discover import Discover, find_unique_values | ||
|
||
# %% | ||
# working with binary to debug | ||
data_lake_path = "data/binary_update/*.parquet" | ||
base_table_path = "data/source_tables/company_employees-yadl-depleted.parquet" | ||
query_column = "col_to_embed" | ||
|
||
|
||
base_table = pl.read_parquet(base_table_path) | ||
# %% | ||
find_unique_values(base_table, ["col_to_embed"]) | ||
# %% | ||
discover = Discover(data_lake_path, [query_column]) | ||
print("fitting") | ||
discover.fit(base_table) | ||
print("transforming") | ||
ranking = discover.transform(base_table) | ||
print(ranking) | ||
|
||
# %% |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import polars as pl | ||
|
||
from skrub._discover import Discover | ||
|
||
if __name__ == "__main__": | ||
# working with binary to debug | ||
data_lake_path = "data/binary_update/*.parquet" | ||
base_table_path = "data/source_tables/yadl/movies_large-yadl-depleted.parquet" | ||
query_column = "col_to_embed" | ||
|
||
base_table = pl.read_parquet(base_table_path) | ||
|
||
discover = Discover(data_lake_path, [query_column]) | ||
print("fitting") | ||
discover.fit(base_table) | ||
print("transforming") | ||
joined_table = discover.transform(base_table) | ||
print(joined_table) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to ignore the files I am using locally to test the object.