Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT use composition in TableVectorizer #675

Closed
wants to merge 32 commits into from

add get_params and set_params to enable grid_search

c0ef079
Select commit
Loading
Failed to load commit list.
Closed

MAINT use composition in TableVectorizer #675

add get_params and set_params to enable grid_search
c0ef079
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Sep 1, 2023 in 1s

78.18% of diff hit (target 92.93%)

View this Pull Request on Codecov

78.18% of diff hit (target 92.93%)

Annotations

Check warning on line 878 in skrub/_table_vectorizer.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

skrub/_table_vectorizer.py#L878

Added line #L878 was not covered by tests

Check warning on line 899 in skrub/_table_vectorizer.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

skrub/_table_vectorizer.py#L899

Added line #L899 was not covered by tests

Check warning on line 989 in skrub/_table_vectorizer.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

skrub/_table_vectorizer.py#L988-L989

Added lines #L988 - L989 were not covered by tests

Check warning on line 1000 in skrub/_table_vectorizer.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

skrub/_table_vectorizer.py#L1000

Added line #L1000 was not covered by tests

Check warning on line 1003 in skrub/_table_vectorizer.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

skrub/_table_vectorizer.py#L1002-L1003

Added lines #L1002 - L1003 were not covered by tests

Check warning on line 1007 in skrub/_table_vectorizer.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

skrub/_table_vectorizer.py#L1007

Added line #L1007 was not covered by tests

Check warning on line 1015 in skrub/_table_vectorizer.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

skrub/_table_vectorizer.py#L1014-L1015

Added lines #L1014 - L1015 were not covered by tests