Fix error when handing over trainer_kwargs to predict_depency() #1366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an error when handing over
trainer_kwargs
topredict_dependency()
, as in the following example:Overwriting
trainer_kwargs
might be necessary when using a model trained on GPU. The issue comes from thekwargs
dict handed over topredict_dependency()
being overwritten inpredict()
, which will cause it to contain aPredictCallback(return_index=True, ...)
in thekwargs["trainer_kwargs"]["callbacks"]
list, even in the second iteration wherereturn_index
should beFalse
, causing a subsequent errorThis PR fixes this by copying the user-specified
kwargs
in every iteration. No tests have been added, as this is a very minor change.Checklist
pre-commit install
.To run hooks independent of commit, execute
pre-commit run --all-files
Make sure to have fun coding!