[MNT] update nbeats/sub_modules.py to remove overhead in tensor creation #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nbeats/sub_module.py raises the following warning: UserWarning: Creating a tensor from a list of numpy.ndarrays is extremely slow. Please consider converting the list to a single numpy.ndarray with numpy.array() before converting to a tensor. This commit replaces the relevant sections with the appropriate code to remove the warning. (similar to sktime#754)
Remove faulty copy commit.
Remove spaces.
fnhirwa
requested review from
benHeid,
fkiraly,
fnhirwa,
geetu040,
jdb78,
pranavvp16,
XinyuWuu and
yarnabrina
as code owners
fnhirwa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR removes a warning raised by nbeats/sub_module.py:
UserWarning: Creating a tensor from a list of numpy.ndarrays is extremely slow. Please consider converting the list to a single numpy.ndarray with numpy.array() before converting to a tensor.This commit replaces the relevant sections with the appropriate code to remove the warning in nbeats submodule. (similar to #754)
Proposed change:
Change the implementation, as suggested by the warning to increase efficiency.