Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Relax numpy bound to numpy<3.0.0 #1624

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

XinyuWuu
Copy link
Member

@XinyuWuu XinyuWuu commented Aug 26, 2024

Relaxes numpy bound to numpy<3.0.0.

(updated by @fkiraly - removed the optuna bound which has been dealt with in #1629)


It should work with newer numpy and optuna version after #1599.

@XinyuWuu
Copy link
Member Author

numpy2 support of torch: pytorch/pytorch#107302 (comment)

macOS x86 builds / test deprecation: pytorch/pytorch#114602

It seems impossible to have numpy2 and torch working in macOS x86.

@fkiraly
Copy link
Collaborator

fkiraly commented Aug 26, 2024

Why is this not a problem in the sktime runners, where we have torch models and also an OS matrix?

@XinyuWuu
Copy link
Member Author

Why is this not a problem in the sktime runners, where we have torch models and also an OS matrix?

Actully we are having torch 2.2.2 and numpy 1.24 for macos in sktime.

@fkiraly
Copy link
Collaborator

fkiraly commented Aug 27, 2024

do you know what causes that? because for sure we have numpy 2 on most jobs (right?)

@XinyuWuu
Copy link
Member Author

do you know what causes that? because for sure we have numpy 2 on most jobs (right?)

pytorch has deprecated macOS x86 after version 2.2.2, but torch 2.2.2 do not suppurt numpy2.

@fkiraly
Copy link
Collaborator

fkiraly commented Aug 29, 2024

I see, so we are forced torch <2.2 because we enforce numpy 2, am I understanding correctly?

@XinyuWuu
Copy link
Member Author

I see, so we are forced torch <2.2 because we enforce numpy 2, am I understanding correctly?

We are forced numpy 1 because we are forced torch<=2.2.2. We can not install torch>2.2.2 in macOS x86 because pytorch has deprecated it after 2.2.2. We can not support numpy 2 in macOS x86 because pytorch supports numpy 2 only with torch>=2.3.0 which can not be installed in macOS x86.

@fkiraly fkiraly changed the title [MNT] Unbound packages numpy and optuna [MNT] Relax numpy bound to numpy<3.0.0 Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants