-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT] Relax numpy
bound to numpy<3.0.0
#1624
base: master
Are you sure you want to change the base?
Conversation
numpy2 support of torch: pytorch/pytorch#107302 (comment) macOS x86 builds / test deprecation: pytorch/pytorch#114602 It seems impossible to have numpy2 and torch working in macOS x86. |
Why is this not a problem in the |
Actully we are having torch 2.2.2 and numpy 1.24 for macos in sktime. |
do you know what causes that? because for sure we have numpy 2 on most jobs (right?) |
pytorch has deprecated macOS x86 after version 2.2.2, but torch 2.2.2 do not suppurt numpy2. |
I see, so we are forced torch <2.2 because we enforce numpy 2, am I understanding correctly? |
We are forced numpy 1 because we are forced torch<=2.2.2. We can not install torch>2.2.2 in macOS x86 because pytorch has deprecated it after 2.2.2. We can not support numpy 2 in macOS x86 because pytorch supports numpy 2 only with torch>=2.3.0 which can not be installed in macOS x86. |
numpy
and optuna
numpy
bound to numpy<3.0.0
Relaxes
numpy
bound tonumpy<3.0.0
.(updated by @fkiraly - removed the
optuna
bound which has been dealt with in #1629)It should work with newer
numpy
andoptuna
version after #1599.