Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] xLSTMTime implementation #1709

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

phoeenniixx
Copy link

@phoeenniixx phoeenniixx commented Nov 9, 2024

Description

This PR tries to implement xLSTMTime based on this paper

see also sktime issue #6793

Checklist

  • Linked issues (if existing)
  • Amended changelog for large changes (and added myself there as contributor)
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

@phoeenniixx phoeenniixx changed the title initial commit [ENH] xLSTMTime implementation Nov 9, 2024
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 315 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@a884c4d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pytorch_forecasting/models/xLSTMTime/mLSTM/cell.py 0.00% 74 Missing ⚠️
pytorch_forecasting/models/xLSTMTime/sLSTM/cell.py 0.00% 64 Missing ⚠️
pytorch_forecasting/models/xLSTMTime/xLSTMTime.py 0.00% 57 Missing ⚠️
...ytorch_forecasting/models/xLSTMTime/mLSTM/layer.py 0.00% 43 Missing ⚠️
...ytorch_forecasting/models/xLSTMTime/sLSTM/layer.py 0.00% 42 Missing ⚠️
...orch_forecasting/models/xLSTMTime/sLSTM/network.py 0.00% 20 Missing ⚠️
...orch_forecasting/models/xLSTMTime/mLSTM/network.py 0.00% 15 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1709   +/-   ##
=======================================
  Coverage        ?   84.37%           
=======================================
  Files           ?       40           
  Lines           ?     5144           
  Branches        ?        0           
=======================================
  Hits            ?     4340           
  Misses          ?      804           
  Partials        ?        0           
Flag Coverage Δ
cpu 84.37% <0.00%> (?)
pytest 84.37% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phoeenniixx
Copy link
Author

hi @fkiraly, I am new to pytorch-forecasting and its tests and all, can you please tell me exactly what am I "missing"?

@phoeenniixx
Copy link
Author

Will these tests suffice @fkiraly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant