Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] clean-up refactor of TimeSeriesDataSet #1746

Open
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Jan 3, 2025

This PR carries out a clean-up refactor of TimeSeriesDataSet. No changes are made to the logic.

This is in preparation for major work items impacting the logic, e.g., removal of the pandas coupling (see #1685), or a 2.0 rework (see #1736).
In general, a clean state would make these easier.

Work carried out:

  • clear, and complete docstrings, in numpydoc format
  • separating logic, e.g., for parameter checking, data formatting, default handling
  • reducing cognitive complexity and max indentations, addressing "code smells"
  • linting

@fkiraly fkiraly added the enhancement New feature or request label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant