add nonkube link status support #1875
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgiorgetti
reviewed
Jan 13, 2025
| return api.GetHostNamespaceHome(p.Namespace) + "/" + string(api.RuntimeSiteStatePath) | ||
| } | ||
|
|
||
| func (p *PathProvider) GetRuntimeNamespace() string { | ||
| return api.GetHostNamespaceHome(p.Namespace) + "/" + string(api.RuntimePath) |
There was a problem hiding this comment.
This is actually retrieving the "static" links generated for a given site (those used by other sites to connect
with it), not the active outgoing links a given site is using.
It seems like GetRuntimeResourceNamespace() is what should have been used here, as it retrieves from
runtime/resources instead. With that, I believe GetRuntimeNamespace is not needed as it is only used by
link_handler.
There was a problem hiding this comment.
ok thanks will fix.
lynnemorrison
force-pushed
the
v2_nk_linkstatus
branch
from
2e58248 to
5122e05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add command and unit tests for nonkube link status
fixes #1871