Simplify flag setup using early platform configuration #1877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config.GetPlatform handles command-line flags etc., using it ensures that user settings are handled consistently. There's no need to duplicate flag-handling in the system subcommand. Signed-off-by: Stephen Kitt <[email protected]>
Since config.GetPlatform is usable during application initialisation (it doesn't rely on cobra), it can be called to determine the platform during cobra setup. Thus platform-specific flags can be declared only if the selected platform is relevant, instead of hiding them after declaring them. Signed-off-by: Stephen Kitt <[email protected]>
skitt
force-pushed
the
early-platform-setup
branch
from
829893d to
2076b44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details.