-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce Quickstart Pipeline image size #347
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmendesky
reviewed
Jul 29, 2024
jmendesky
reviewed
Jul 29, 2024
jmendesky
reviewed
Jul 29, 2024
adriangay
requested review from
a team and
jmendesky
and removed request for
a team
July 30, 2024 06:43
TobyPinfold
approved these changes
Jul 30, 2024
Ankitha-Krisshnan
approved these changes
Jul 30, 2024
jmendesky
reviewed
Jul 30, 2024
jmendesky
reviewed
Jul 30, 2024
jmendesky
approved these changes
Jul 30, 2024
aidandunlop
force-pushed
the
reduce-quickstart-image-size
branch
from
July 30, 2024 15:48
e437d31
to
a46bbc9
Compare
OK to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #346
The quickstart pipeline uses the TFX image as it's base, which is ~9GB and includes several extra tools which aren't needed by the quickstart pipeline. This PR uses a slim python image as the base instead, and installs the
tfx
python package and other dependencies directly which will reduce the image size dramatically.Image size when using base TFX image:
Image size after using
tfx
python package on slim python:We encountered a recent breaking change in the
setuptools
dependency indirectly imported by TFX which was causingCsvExampleGen
to fail (see main card). This was fixed by pinning the dependency version.Tasks