-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New ZTF alert schema - Forced photometry #258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mcoughlin for this first PR I settled for the simpler logic:
I think this is fine, and easy to implement until we know what most users agree with. Will discuss it this week during multiple meetings with different working groups. |
Don't mind the +4k lines, it's just the avro files |
@mcoughlin sorry to bug you again. Got Mansi's input. She thinks that for now, what is really valuable is mostly forced photometry that comes with the first ever alert for a given object, as it gives us potential detections that pre-date the alert pipeline's discovery of the object. And therefore, updating it is not as important as the prv_candidates, and we can just ingest it for the very first alert and stop there (ignore new forced photometry). At least until everyone agrees on what is best. |
Ok @Theodlz ! |
THe latest ZTF alert schema will now include forced photometry, not included in the
prv_candidates
array, but in it's ownfp_hists
array field.This PR adds the necessary support to ingest that data, and a unit test to verify it.
TODO:
prv_candidates
, the content offp_hists
changes with time, so it's unclear to me how to best deduplicate that data. For theprv_candidates
, we can just use MongoDB's$set
operator as the data points are identical (except new ones of course). Here, past data points might not be identical, so that might not work perfectly. Unfortunately, IPAC provides tarballed alert packets for only a night, so hard to test that behavior with little data.