Ingest Catalogs: get position from existing catalog (by id) #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by id) with an existing spatial catalog
mcoughlin
approved these changes
Mar 15, 2024
2024 and API's are still a luxury not a standard 🤡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some catalogs like PS1-PSC (provides star/galaxy score for all PS1 sources) do not provide coordinates, but the identifier of an object in another catalog that has the coordinates.
This PR adds the code needed to crossmatch (by id) new entries to the entries of an existing catalog to fetch the relevant coordinates, and add them as the coordinates of the documents of the new catalog.
Also, we refactor the main method to split it in 3 methods, one per file format