FP hists: filter out bad/weird procstatus #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though the processing worked, some datapoints have warnings, and these signify that the data might not be what you'd expect.
In prod we noticed a lot of deep non-detections too close to detections, and filtering out the "bad" data seems to help, though I am a bit worried about how much we will just not see anymore, but it seems like the best options right now.
We still store the data in Kowalski, but we just do not push the forced phot to Fritz if the procstatus is not "0". And yes, the 0 is a string in the ZTF alert schema...