Fix saveable state being restored when using reset root navigation events #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbanes
force-pushed
the
cb/saveable-saved-backstack
branch
from
41c769d
to
b185cc5
Compare
chrisbanes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates
NavigableCircuitContentto useSaveableStateHolder, rather than our hand-rolledSaveableStateRegistryBackStackRecordLocalProvider.I don't know the history behind
SaveableStateRegistryBackStackRecordLocalProvider, butSaveableStateHolderis the first party solution for this. It is used by AndroidX Navigation, so we can assume it is well tested.This PR relies on a bunch of
movableContentfixes added in #1282 (I had to add a similar one in this PR forCupertinoGestureNavigationDecoration).Fixes #1342