Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: basic Z-plot widget #908

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

ENH: basic Z-plot widget #908

wants to merge 4 commits into from

Conversation

YektaY
Copy link
Collaborator

@YektaY YektaY commented Aug 26, 2022

Description

A basic Z-plot widget.

The Z-plot widget is to plot data along a physical dimension of a facility (at SLAC the z-dimension of the accelerator) and provide a dynamic symbolic diagram of the facility corresponding to the given data points.

The idea here is that this basic Z-plot widget could serve as a base template z-plot widget. It provides a basic plotting widget, which could be used on it's own, but lacks more convenient methods for gathering data and corresponding symbols for the plot.

Question:

This is a draft PR because documentation is still being written at the moment. In the mean time I wanted to see if this would be something which would be a good fit for PyDM. If it is a good fit, are there any additional features or changes which could enhance this basic z-plot widget?

Motivation and Context

SLAC had a need for a z-plot to plot PVs along the accelerator. Offering up this stripped down version as a base z-plot widget in case other users of PyDM may have need for a similar widget.

How Has This Been Tested?

Tested on an example Gui.

Where Has This Been Documented?

documentation is still being worked on.

Screenshots:

Screen Shot 2022-08-26 at 9 26 44 AM

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2022

Codecov Report

Merging #908 (cfd855c) into master (275c26f) will decrease coverage by 0.45%.
The diff coverage is 25.23%.

@@            Coverage Diff             @@
##           master     #908      +/-   ##
==========================================
- Coverage   60.20%   59.75%   -0.46%     
==========================================
  Files         102      103       +1     
  Lines       12802    12999     +197     
==========================================
+ Hits         7707     7767      +60     
- Misses       5095     5232     +137     
Impacted Files Coverage Δ
pydm/widgets/z_plot.py 23.80% <23.80%> (ø)
pydm/widgets/__init__.py 100.00% <100.00%> (ø)
pydm/widgets/shell_command.py 69.84% <0.00%> (-10.02%) ⬇️
pydm/widgets/related_display_button.py 65.06% <0.00%> (-7.00%) ⬇️
pydm/widgets/symbol.py 52.58% <0.00%> (-0.81%) ⬇️
pydm/widgets/label.py 100.00% <0.00%> (ø)
pydm/widgets/base.py 90.34% <0.00%> (+0.03%) ⬆️
pydm/widgets/embedded_display.py 23.50% <0.00%> (+0.67%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants