fix: empty strings in base translations should not be removed

slang-i18n · Dec 1, 2024 · bd9692d · bd9692d
1 parent e5f934b
commit bd9692d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/slang/CHANGELOG.md b/slang/CHANGELOG.md
@@ -1,6 +1,7 @@
 ## 4.4.0
 
 - feat: add `(fallback)` modifier to fallback entries within a map (#268)
+- fix: empty strings in base translations should not be removed when using `fallback_strategy: base_locale_empty_string`
 
 ## 4.3.0
 

diff --git a/slang/lib/src/builder/builder/translation_model_builder.dart b/slang/lib/src/builder/builder/translation_model_builder.dart
@@ -304,7 +304,8 @@ Map<String, Node> _parseMapNode({
       // leaf
       // key: 'value'
 
-      if (config.fallbackStrategy == FallbackStrategy.baseLocaleEmptyString &&
+      if (baseData != null &&
+          config.fallbackStrategy == FallbackStrategy.baseLocaleEmptyString &&
           value is String &&
           value.isEmpty) {
         return;