This repository has been archived by the owner on Sep 19, 2018. It is now read-only.
Add Tiers, Playlist, ranked seasons parsing, leaderboards, docs links #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z64
changed the title
z64
force-pushed
the
dev/tiers
branch
2 times, most recently
from
b3b2227 to
7162541
Compare
z64
commented
Jul 20, 2017
| # @param playlist_id [Integer] | ||
| # @return [Array<Player>] | ||
| def ranked_leaderboard(playlist_id) | ||
| raise ArgumentError, 'Invalid playlist_id' unless playlists.keys.include?(playlist_id) |
There was a problem hiding this comment.
FWIW: This does indeed make this the first endpoint that executes another API request (potentially) but I'd rather do this than send a bad request. Let me know if you think otherwise.
Edit:
I'm also not 100% sure ArgumentError is the right thing here, because the whether or not the argument is rejected is based on outside conditions (API) that can't be known by the code itself. It's not really that important, but leaning towards making a custom exception just to clarify this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo:
Player#ranked_seasons#ranked_seasonsdata into their full cached counterparts (season, playlist, tier)