Fixed breaks not being called and two other problems #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed SafeEyes breaks not being called (crashing) when Chromium snap refuses dbus access
|
There you go. |
deltragon
requested changes
Jan 28, 2024
| @@ -194,7 +194,8 @@ def __start_idle_monitor(): | |||
| smart_pause_activated = True | |||
| idle_start_time = datetime.datetime.now() - datetime.timedelta(seconds=system_idle_time) | |||
| logging.info('Pause Safe Eyes due to system idle') | |||
| disable_safeeyes(None, True) | |||
| info = _('Paused Safe Eyes due to system being idle') | |||
| disable_safeeyes(info, True) | |||
There was a problem hiding this comment.
Hmm, this still doesn't work for me - now it fails with
TypeError: SafeEyes.__init__.<locals>.<lambda>() takes 1 positional argument but 2 were given
I guess the is_resting parameter has to be passed along in the lambda in safeeyes/safeeyes.py:74 as well:
Lines 74 to 75 in 6ac8b60
|
@adventuretc Any updates? |
|
Are these changes still relevant? The current version of safeeyes is not anymore compatible with Ubuntu 20.04, so fix is not anymore relevant. Also, does safeeyes still not work with Chromium snap? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The title and the commit messages should say it all.
Kindly, merge the changes.