-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module for HTMX SSE extension #5
Conversation
h0p3zZ
commented
Jul 15, 2024
- Added SSE extension support in seperate library
- Example code vor Vapor and Hummingbird
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution.
I really think the addition of a little sse-based live time view does not justify adding (and maintaining) two more example projects. Also, moving the existing examples will break existing links to them (in forum posts or similar)
Please rework the examples to keep the existing folder structure and simply add the live-time view snippets in there. It will be nice to have a little annotation on the page highlighting that the time is actually the "server time" or similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost there
Examples/HummingbirdDemo/Sources/App/ElementaryHTMXSSE+Hummingbird.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (tiny example fixes are needed, but I'll do them separately)