Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: testimonials #42

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SandalikaAriyrathna
Copy link
Contributor

testimonials

'relative bg-white aspect-rectangle flex flex-col justify-center rounded-2xl p-6 text-black shadow-md',
testimonial.styles?.wrapper
)}
style={{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use tailwind classes for this?

</div>

{/* Inline keyframes for the scroll animation */}
<style jsx>{`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tailwind for these styles too

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SandalikaAriyrathna style tag is still here.

<SectionBadge id="sponsors">Testimonials</SectionBadge>
<div
className="grid grid-flow-col auto-cols-[33%] gap-8"
style={{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we replace these also with tailwind

gridTemplateColumns: 'repeat(auto-fill, minmax(33%, 1fr))', // 3 boxes per row
animation: 'scroll-reel 20s linear infinite'
}}>
{testimonials.concat(testimonials).map((testimonial, index) => (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we use concat here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for adding concat?

Copy link

github-actions bot commented Sep 16, 2024

PR Preview Action v1.1.2
🛫 Deployed preview to https://bashaway.sliitfoss.org/preview/pr-42/
on branch gh-pages at 2024-09-22 13:42 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants