Add support for TPP MLIR #134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not good. Upon enabling TPP_MLIR, too many binaries ends up needing the library even the ones that apparently have nothing to do with it. I'll close this PR, update the branch with my latest update and call it a day. @slyalin if you know how to work the CMake magic to enable TPP-MLIR default passes only on the Python side, feel free to take the branch as a starting point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now it doesn't do much, since the IR we get has no GEMMs in it, but it does enable that path, so we can develop it in parallel. Both MLIR and LIBXSMM are already in the build, so no need to add them.
Long term we want to not have this dependency, though, so this is just a way to get things going.