Merge pull request #651 from smapiot/fix/piral-translate-do-not-repla…

…ce-falsy-vars-with-empty-string

`piral-translate`: Do not replace falsy variables with an empty string

src/plugins/piral-translate/src/localize.test.ts

@@ -8,6 +8,7 @@ const messages = {
   en: {
     hi: 'hello',
     greeting: 'Hi {{name}}, welcome back',
+    secretNumber: 'The secret number is {{number}}.',
     header: {
       title: 'Hello world'
     }
@@ -80,6 +81,12 @@ describe('Localize Module', () => {
     expect(result).toBe('Hi , welcome back');
   });
 
+  it('localizeGlobal does not replace falsy variables with an empty string', () => {
+    const localizer = new Localizer(messages, 'en');
+    const result = localizer.localizeGlobal('secretNumber', { number: 0 });
+    expect(result).toBe('The secret number is 0.');
+  });
+
   it('localizeGlobal translates from global translations using passed nested translations', () => {
     const localizer = new Localizer(messages, 'en');
     const result = localizer.localizeGlobal('header.title');

src/plugins/piral-translate/src/localize.ts

@@ -16,7 +16,7 @@ function defaultFallback(key: string, language: string): string {
 
 function formatMessage<T extends object>(message: string, variables: T): string {
   return message.replace(/{{\s*([A-Za-z0-9_.]+)\s*}}/g, (_match: string, p1: string) => {
-    return p1 in variables ? variables[p1] || '' : `{{${p1}}}`;
+    return p1 in variables ? variables[p1] ?? '' : `{{${p1}}}`;
   });
 }