Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Exclude target from pack #642

Merged

Conversation

manuelroemer
Copy link
Member

New Pull Request

For more information, see the CONTRIBUTING guide.

Prerequisites

Please make sure you can check the following boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • All new and existing tests passed

Type(s) of Changes

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have updated the documentation accordingly
  • I have added tests to cover my changes

Description

Removes the target .tgz file from the list of files to be packed in the pilet pack command. This should solve an issue where packing of pilets fails when the target exists in the dist directory, e.g., as a leftover from a previous build.

Remarks

None.

@manuelroemer manuelroemer changed the title fix: Exclude target from pack. fix: Exclude target from pack Nov 13, 2023
Copy link

File size impact

Merging fix/pilet-pack-throws-when-target-exists-in-dist into develop impact files as follow:

empty-piral (no impact)
Files new size
Unmodified (2) 28.8 kB (0 B / +0%) 👻
Total (2) 28.8 kB (0 B / +0%) 👻
minimal-piral (no impact)
Files new size
Unmodified (2) 254 kB (0 B / +0%) 👻
Total (2) 254 kB (0 B / +0%) 👻
sample-cross-fx (no impact)
Files new size
Unmodified (3) 2.26 MB (0 B / +0%) 👻
Total (3) 2.26 MB (0 B / +0%) 👻
sample-piral (no impact)
Files new size
Unmodified (3) 645 kB (0 B / +0%) 👻
Total (3) 645 kB (0 B / +0%) 👻
sample-piral-core (no impact)
Files new size
Unmodified (3) 308 kB (0 B / +0%) 👻
Total (3) 308 kB (0 B / +0%) 👻
Generated by @jsenv/file-size-impact during check-bundle-size#6848910626 on 6d2cc4d

@FlorianRappl FlorianRappl added the cli Concerns the piral-cli application. label Nov 13, 2023
@FlorianRappl FlorianRappl added this to the 1.4.0 milestone Nov 13, 2023
Copy link
Contributor

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FlorianRappl FlorianRappl merged commit 1ecddf6 into develop Nov 13, 2023
3 of 5 checks passed
@FlorianRappl FlorianRappl deleted the fix/pilet-pack-throws-when-target-exists-in-dist branch December 13, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Concerns the piral-cli application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants