Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Updates for pytest 8.1 and python 3.12 #67

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

larsoner
Copy link
Contributor

@larsoner larsoner commented Feb 20, 2024

Supersedes #65

Modernizes some stuff:

  • Updates for Pytest 8.1
  • Use packaging to get module versions rather than distutils (which is gone in 3.12)
  • Set Python min to 3.8 (3.7 is EOL)
  • Set pytest min to 6 (almost 4 years old)
  • Remove six because with 3.8 min we can
  • Test on CI and adapt to 3.12

If it's not desired to drop python_version < 3.8 I can get rid of all that stuff and restore tests etc. This just seemed like the cleanest / most maintainable way forward to me!

@larsoner
Copy link
Contributor Author

... and pytest 6 came out June 2020, so almost 4 years ago. I think it's okay to require that as a minimum as well. (Anyone on an ancient version of pytest can stick with an older version of pytest-harvest, no?)

@larsoner
Copy link
Contributor Author

This is now hitting smarie/python-pytest-cases#330 I think (found from pytest-dev/pytest#11868 (comment)) but otherwise is in good shape I think! So for now I'll get rid of the -latest case.

@smarie
Copy link
Owner

smarie commented Mar 15, 2024

Great stuff @larsoner ! Thanks so much for spending time to work on this.

I'll switch the backend to vitualenv first, so I'll start from this PR #70

Then I'll merge interesting stuff from your branch in.
Hopefully this will happen in the upcoming days, I'll keep you posted

@smarie
Copy link
Owner

smarie commented Mar 16, 2024

I merged the PR to release a first version 1.10.5 with some of your fixes and others.

I am now totally in favour of moving forward with your proposals (python 3.8 and pytest 6). Could you just update this PR to the latest, I'll have a look afterwards. No particular hurry of course.

@larsoner
Copy link
Contributor Author

@smarie looks like the conflicts are bad, feel free to take over in a new PR if you want!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants